Wunderground configuration password is not sent correctly

[peterh]

Hi.

I just so happen to have a comma (,) in my Wunderground password.
Or I had. Because I got INVALIDPASSWORDID twice in a row in my debug.log. It had sent the password with a dot rather than a comma. On inspecting the cumulus.ini file, I saw that in there, the password was correct (with a comma rather than a dot).

I've changed my Wunderground password to a password not containing interpunction... and now it works.

[steve]

How do you know it was sending a dot rather than a comma? There's nothing in Cumulus that would do that conversion. I'm not surprised to hear that a comma caused a problem, though.

[peterh]

How do you know it was sending a dot rather than a comma?

Because even though, in the Cumulus.ini, the password was correct (with a comma):

Code: Select all

[Wunderground]
ID=IUTRECHT58
Password=**,*****
Enabled=1
RapidFire=0
Interval=10
SendUV=1
SendSR=1
SendAverage=1
CatchUp=1

in the debug.log file it said:

Code: Select all

7979.4745 : http://weatherstation.wunderground.com/weatherstation/updateweatherstation.php?ID=IUTRECHT58&PASSWORD=**.*****&dateutc=2013-01-
01+13%3A30%3A01&winddir=270&windspeedmph=11.4&windgustmph=15.2&windspdmph_avg2m=8.3&winddir_avg2m=303&humidity=74&tempf=47.1&rainin=0.00
&dailyrainin=0.38&baromin=29.705&dewptf=39.3&UV=1.0&solarradiation=230&softwaretype=Cumulus%20v1.9.2&action=updateraw
7979.5385 : 14:30:02 WU Response Code: 200 Response = INVALIDPASSWORDID|Password and/or id are incorrect

(Yes, I have masked the password with asterisks, except for the comma/period. You'd never guess it, anyway).

And I *am* surprised that a comma caused a problem. :-p
On second thought: I am guessing that you have code somewhere that replaces a decimal comma with a decimal period... probably because that's what Wunderground wants. It *must* be something like that... probably in the code where you compile the web request to be sent to Wunderground... amirite?

[steve]

On second thought: I am guessing that you have code somewhere that replaces a decimal comma with a decimal period... probably because that's what Wunderground wants. It *must* be something like that... probably in the code where you compile the web request to be sent to Wunderground... amirite?

Yes, you're absolutely correct and I'd forgotten that it works that way rather than modifying the individual items

So, yes, it needs to be changed at some point.

In 1.9.3, the password is 'asterisked' in the debug.log, so you wouldn't have been able to see what was being sent. I thought that 1.9.2 was the same, but clearly not.

[peterh]

On second thought: I am guessing that you have code somewhere that replaces a decimal comma with a decimal period... probably because that's what Wunderground wants. It *must* be something like that... probably in the code where you compile the web request to be sent to Wunderground... amirite?

Yes, you're absolutely correct and I'd forgotten that it works that way rather than modifying the individual items

I've been coding too long to not spot these things

In 1.9.3, the password is 'asterisked' in the debug.log, so you wouldn't have been able to see what was being sent. I thought that 1.9.2 was the same, but clearly not.

An observation:
If it WOULD have been the same, it would've taken me a *lot* longer to figure out. So, please do not asterisk this out!

[steve]

If it WOULD have been the same, it would've taken me a *lot* longer to figure out. So, please do not asterisk this out!

Well, yes, but unfortunately I can't expect people to upload debug.log files with passwords in, so in 1.9.3 they're not visible.

[peterh]

If it WOULD have been the same, it would've taken me a *lot* longer to figure out. So, please do not asterisk this out!

Well, yes, but unfortunately I can't expect people to upload debug.log files with passwords in, so in 1.9.3 they're not visible.

In that case, we would want to be absolutely, positively sure we do not change the password string in any way.
Or we create an extra debugging option, something like "Include account information in debug file (including passwords)".

Let me think about this for awhile and get back to you.