Upload now broken 3.24.2

[AndyKF650]

Hi there

I tried this fix and once I had loaded it in the correct place it worked perfectly. I have attached my MXDiags file for information, the line at 448 was when the new file was in the wrong place and hence not working, then at 465 to 472 shows the graph file transfers as expected.

[HansR]

I have no error in the debug logs from yesterday evening until now (there were two restarts included.

I did notice however, that the log from Andy (see previous post) does have those errors e.g.:

Code: Select all

2023-03-15 18:16:12.696 Normal running
2023-03-15 18:16:14.852 SendLoopCommand: Starting - LOOP 50
2023-03-15 18:17:31.250 LoadDayFile: Attempting to load the day file
2023-03-15 18:17:32.400 LoadDayFile: Loaded 3702 entries to recent daily data list
2023-03-15 18:17:43.880 Upload Now: Specified argument was out of the range of valid values.
Parameter name: start
2023-03-15 18:17:48.214 Upload Now: Specified argument was out of the range of valid values.
Parameter name: start
2023-03-15 18:17:49.311 SendLoopCommand: Starting - LPS 2 1
2023-03-15 18:17:49.381 SendLoopCommand: Starting - LOOP 50
2023-03-15 18:17:51.318 Upload Now: Specified argument was out of the range of valid values.
Parameter name: start
2023-03-15 18:19:27.310 SendLoopCommand: Starting - LPS 2 1
2023-03-15 18:19:27.380 SendLoopCommand: Starting - LOOP 50
2023-03-15 18:19:50.906 Ecowitt Gateway uptime = 353982 secs - 4.02:19:42
2023-03-15 18:20:00.284 DoLogFile: Writing log entry for 15/03/2023 18:20:00
2023-03-15 18:20:00.289 DoLogFile: log entry for 15/03/2023 18:20:00 written
2023-03-15 18:20:00.310 Writing today.ini, LastUpdateTime = 15/03/2023 18:20:00 raindaystart = 158.8 rain counter = 158.8

And searching the code for a start argument leads me to believe it has something to do with int.parse or string.parse statements somewhere (as that is where the start argument is present).

I switch debug off now and expect that will generate those errors again, apparently it has some timing component in it.
It does not seem to have immediate consequences but on the other hand it does not look trustworthy.