Bug still with 1st of each month in v1.1.0: (BUG: Create Missing Version 1.0.2)
Posted: Tue 08 Jun 2021 7:05 pm
I recently found the middle of my Jun20log.txt file was corrupted on my RPi. I am unsure why, perhaps because June was when I was experimenting with MX.
Luckily, I had a full replacement made when I was testing my "Create Missing php script" last year, so my RPi standard log files are now all correct.
Today I thought I would try out your recent CreateMissing.exe to see whether it would find any updates were needed in my dayfile.txt.
Bug:
After running CreateMissing.exe, I have had to go back to the older dayfile.txt as your program has removed one line from every month in the dayfile.txt where other dates in the month had feels like added, before dates when humidex added.
The output says for example
However, from August onwards (after you added Humidex to MX) I was running CumulusMX.exe that had stored a complete line in dayfile.txt correctly, and so your new program reports
Observations:
1) I did discover that because I ran this on my Microsoft Windows PC accessing my RPi files, the original and revised files also had different end of line characters (the old file has LF as end of line because it is creating using Linux variant, the new file has CRLF as end of line because I ran it using an emulator on my PC), but that is something I did not think about, not a bug by you.
2) I also noticed that while Cumulus 1 truncated trailing zeroes in decimal places when storing values in the file, your newer program is storing all decimals to a fixed number of decimal places.
EDIT: The title of this thread has been changed, basically to confirm that the newer version of CreateMissing (v.1.1.0) still has the bug that it does not amend any dayfile line that is the first of the month, (? maybe because I use 9am/10am rollover ?). However, the new version of CreateMissing.exe does NOT remove the entry for those earlier months where previous version removed those lines, so there is some improvement. Of course another difference is that the new version adds both Humidex and Cumulative Chill Hours to every line, although because it skips the first of the month, the Chill Hour figures it adds miss one day each month!
Luckily, I had a full replacement made when I was testing my "Create Missing php script" last year, so my RPi standard log files are now all correct.
Today I thought I would try out your recent CreateMissing.exe to see whether it would find any updates were needed in my dayfile.txt.
Bug:
After running CreateMissing.exe, I have had to go back to the older dayfile.txt as your program has removed one line from every month in the dayfile.txt where other dates in the month had feels like added, before dates when humidex added.
The output says for example
on the first of every month. That message is wrong, the monthly data does correctly exist in the standard log file for each of those starts of a new month (so it should have found it), also your program has removed from dayfile.txt the existing line for the first of every month in that period (so it has done an update).Date: 01/02/2020 : Adding missing data ...
01/02/2020 : No monthly data was found, not updating this record
...
Date: 01/07/2020 : Adding missing data ...
01/07/2020 : No monthly data was found, not updating this record
However, from August onwards (after you added Humidex to MX) I was running CumulusMX.exe that had stored a complete line in dayfile.txt correctly, and so your new program reports
and indeed the line for those first of the month is left in dayfile.txt for all those months.Date: 01/08/2020 : Entry is OK
...
Date: 01/06/2021 : Entry is OK
Observations:
1) I did discover that because I ran this on my Microsoft Windows PC accessing my RPi files, the original and revised files also had different end of line characters (the old file has LF as end of line because it is creating using Linux variant, the new file has CRLF as end of line because I ran it using an emulator on my PC), but that is something I did not think about, not a bug by you.
2) I also noticed that while Cumulus 1 truncated trailing zeroes in decimal places when storing values in the file, your newer program is storing all decimals to a fixed number of decimal places.
EDIT: The title of this thread has been changed, basically to confirm that the newer version of CreateMissing (v.1.1.0) still has the bug that it does not amend any dayfile line that is the first of the month, (? maybe because I use 9am/10am rollover ?). However, the new version of CreateMissing.exe does NOT remove the entry for those earlier months where previous version removed those lines, so there is some improvement. Of course another difference is that the new version adds both Humidex and Cumulative Chill Hours to every line, although because it skips the first of the month, the Chill Hour figures it adds miss one day each month!