Page 1 of 2

Minor graph issue2

Posted: Mon 10 May 2021 5:59 pm
by The PIT
Just noticed that when using the latest templates for trends.htm anf historic.htm they don't resize properly when going from full screen. I haven't updated the selectgraph and that works properly.

See https://www.sheffieldweather.net/trends2.htm and https://www.sheffieldweather.net/historic2.htm

Just noticed something else and that a # gets added to the end url for these pages and haven't a clue why.

Re: Minor graph issue2

Posted: Tue 11 May 2021 9:11 am
by mcrossley
They resize OK for me?

The # fragment is the update that gives you the ability to link directly to a particular graph, rather than load the default graph.

eg. Your recent wind graph - https://www.sheffieldweather.net/trends2.htm#wind

Re: Minor graph issue2

Posted: Tue 11 May 2021 3:13 pm
by Mapantz
I see it.

If you go to full screen and back out again, the graph container becomes tall, not the size it was when the page was first loaded.

Re: Minor graph issue2

Posted: Tue 11 May 2021 4:08 pm
by mcrossley
Which browser are you using - I do not see that behaviour in Edge.

Also desktop or mobile?

Re: Minor graph issue2

Posted: Tue 11 May 2021 5:03 pm
by Mapantz
Edge / Desktop

Re: Minor graph issue2

Posted: Tue 11 May 2021 6:03 pm
by PaulMy
I can duplicate what Mapantz mentioned and also in Edge, with PC Windows 10.
One image is page from initial Trends selection, and the other after exit full screen.

p.s. difference trends content is that one is CMX with Vue/WiFiLogger and the other with CMX and WLL

Enjoy,
Paul

Re: Minor graph issue2

Posted: Tue 11 May 2021 8:25 pm
by mcrossley
Nope still cannot reproduce - can you give me some screen resolutions, and browser window sizes (you can get the latter in dev tools).

And when you say "full screen", you do mean pressing F11 and not "maximised" - I cannot reproduce with either though!

Re: Minor graph issue2

Posted: Tue 11 May 2021 9:17 pm
by Mapantz
mcrossley wrote: Tue 11 May 2021 8:25 pm Nope still cannot reproduce - can you give me some screen resolutions, and browser window sizes (you can get the latter in dev tools).

And when you say "full screen", you do mean pressing F11 and not "maximised" - I cannot reproduce with either though!
Clicking the burger menu on the highcharts graph and then clicking 'view in full screen'

Re: Minor graph issue2

Posted: Tue 11 May 2021 11:34 pm
by PaulMy
Hi Mark,
As Mapantz mentioned - Clicking the burger menu on the highcharts graph and then clicking 'view in full screen' and then 'Exit from full screen'.
My screen resolution is the Windows recommended 1920 x 1080
I've tried to find the browser window sizes but haven't found that yet :oops:

Enjoy,
Paul

Re: Minor graph issue2

Posted: Wed 12 May 2021 8:54 am
by mcrossley
Ah right - the HighCharts full screen mode!

It's a bug in HighCharts - https://github.com/highcharts/highcharts/issues/13222

Looks like they have fixed it, looks like it is in v9.1.0 which is three releases up from where we are - including a major release. So more testing required before I could jump to that.

You could try as an experiment changing the pages script URL to: https://code.highcharts.com/stock/9.1/highstock.js
And see if 1. It fixes the issue, 2. Anything else breaks!

Re: Minor graph issue2

Posted: Wed 12 May 2021 10:13 am
by HansR
Don't know if this helps, but in CumulusUtils I always use the current stable version from CDN: https://code.highcharts.com/stock/highstock.js (so that's 9.1 at the moment) and there is no problem. So I assume that can be seen as a first test.

Re: Minor graph issue2

Posted: Wed 12 May 2021 10:27 am
by mcrossley
I've been bitten one too many times by HighCharts changing things in updates that break my graphs to stay on latest. :( That's why I have pinned to minor versions, it still allows fixes to that version to be picked up but not anything major. The problem is you then have to periodically update.

Re: Minor graph issue2

Posted: Wed 12 May 2021 10:47 am
by HansR
mcrossley wrote: Wed 12 May 2021 10:27 am I've been bitten one too many times by HighCharts changing things in updates that break my graphs to stay on latest. :( That's why I have pinned to minor versions, it still allows fixes to that version to be picked up but not anything major. The problem is you then have to periodically update.
You have been working with HighCharts a bit longer than me, can't beat that experience ;)
I assume in 2012 - wasn't that when you started with HC - it was less stable with less process control then it is now.
So far (two years now) I have not seen any problems with my method.
Confidence 8-)

Re: Minor graph issue2

Posted: Wed 12 May 2021 4:51 pm
by The PIT
Ahh it's a highcharts issue.
Yup changing the script to 9.1 fixes it can't see anything else broken.
Should have mentioned Browsers and resolutions. Sometimes you've got to remember to be precise and say you've tested different browsers and platforms etc.
Looks like notepad++ time.

Re: Minor graph issue2

Posted: Wed 12 May 2021 5:10 pm
by The PIT
Editing done.

One more thing is there anyway to make sure that the menu buttons when they wrap they are centralised. It looks a bit daft when you say you may get two on the left hand side while straight in middle would look much better.

See attached screen shot.