minimising the graph data files issue

[duke]

Ok, not strictly an MX issue but a possible problem with 'd3.v3.js' & 'nv.d3.js' when minimised.

So I have the graphs working fine on a website with their un-minimised js but when minimised they cause the graphs to either load unbearably slow and with errors or FireFox produces a message stating the script is busy or has stopped responding.

It's definitely these two causing issues as when replaced with un-minimised files there are no issues.

When I use closure-compiler to minimise the scripts it shows several warnings - related?

For d3.v3 it shows:

JSC_USELESS_CODE: Suspicious code. The result of the 'not' operator is not being used. at line 1 character 0
!function() {

JSC_USELESS_CODE: Suspicious code. The result of the 'getprop' operator is not being used. at line 13 character 0
d3_array(d3_documentElement.childNodes)[0].nodeType;

JSC_SUSPICIOUS_SEMICOLON: If this if/for/while really shouldn't have a body, use {} at line 1013 character 40
while (!(node = group[i0]) && ++i0 < n) ;

JSC_SUSPICIOUS_SEMICOLON: If this if/for/while really shouldn't have a body, use {} at line 5735 character 53
while (--i >= 0 && !(f = d3.interpolators(a, b))) ;


and for nv.d3 it shows:

JSC_USELESS_CODE: Suspicious code. This code lacks side-effects. Is there a bug? at line 1100 character 5
for (i; i < data.length; i += 1) {

I've high lighted the warnings in red.


Attached the latest versions of these files, d3 is now upto v3.5.3 and nv.d3 is 1.7.0 as included with MX

[steve]

This is not something I know anything about, so I can't help, but do the supplied minimised versions not work?

[steve]

I see that I haven't included the v3 minimised version, attached. Using that and the supplied nv.d3.min.js seems to work OK for me - http://sanday.org.uk/weather/trends.htm

[duke]

I had previously got the already minimised versions from github .

Yes your page does work for me and I've just discovered so does mine, but, both pages how ever stop when I have Firebug open - which I have open as default. Replacing the un-minimised js and all is ok when Firebug is open.

Screen capture attached from your page and a link to my test page

[steve]

Presumably because of the synchronous Ajax call to load the data file, which Firebug will be including in the running time of the script? I have no idea why it apparently wouldn't do that with the un-minimised versions of those two scripts. But as far as I can tell, it's all working as it was intended to, whether the scripts are minimised or not.