Time Zone warning message in NOAA php script - help please!

[RayProudfoot]

Steve has moved my web hosting to a new server in the last 24 hours. He's notified me of a warning that is being repeatedly issued on one of my php scripts. When I say my they haven't been written by me, just a kindly forum member a few years ago.

This is the warning message...

PHP Warning: getdate(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected the timezone 'UTC' for now, but please set date.timezone to select your timezone. in /home/cheadlehulmeweather/www/NOAA-reports.php on line 161

Looking at that php file I have the following for the time zone...

$ourTZ = 'Europe/London'; // set your timezone - see: http://php.net/manual/en/timezones.php

And a little further on is this code...

<?php
if (!isset($PHP_SELF) ) { $PHP_SELF = $_SERVER['PHP_SELF']; }
putenv("TZ=$ourTZ");
$now = getdate();
print "<!-- now\n" . print_r($now,true) . " -->\n";
$now_month = sprintf("%02d",$now['mon']);
$now_year = $now['year'];
$prior_month = $now['mon'] - 1;
$prior_year = $now['year'];
$last_year = $prior_year -1;
if ($prior_month < 1) { $prior_month = 12; $prior_year--; }
$prior_month = sprintf("%02d",$prior_month);
print "<!-- parms: yr = '$yr' | mo = '$mo' -->\n";
print "<!-- now = '$now_month'-'$now_year' | prior = '$prior_month'-'$prior_year' -->\n";

I have highlighted the only reference to that variable.

Can anyone help in resolving this warning please? The code does contain the correct time zone entry for my location so I'm a bit mystified.

[mcrossley]

Ray, try changing it to...

Code: Select all

date_default_timezone_set($ourTZ);

[saratogaWX]

The updated version of my scripts include the code

Code: Select all

if (!function_exists('date_default_timezone_set')) {
	
	if (! ini_get('safe_mode') ) {
	   putenv("TZ=$ourTZ");  // set our timezone for 'as of' date on file
	}
//	 print "<!-- using putenv(\"TZ=". $SITE['tz']. "\") -->\n";
  } else {
   date_default_timezone_set($ourTZ);
//	 print "<!-- using date_default_timezone_set(\"". $ourTZ. "\") -->\n";
 }

so it handles both situations

[RayProudfoot]

Ray, try changing it to...

Code: Select all

date_default_timezone_set($ourTZ);

Mark,

Sorry, change which bit to the above? In the declaration section up at the top or further down in the code?

Ken, you'll appreciate this code was modified for me as my knowledge of php is zero. Preferably I want to change the minimum required to resolve the warning message.

[mcrossley]

Just replace the red bit you highlighted. Ken's code is a good general solution, but the one line change should get you going.

[RayProudfoot]

Thanks Mark. I've changed that line and uploaded the new version to the web server.

I'll await Steve's reply tomorrow.

[steve]

That's done the trick - thanks, everyone